r76857 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r76856‎ | r76857 | r76858 >
Date:23:46, 16 November 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Last (bug 25899) Show header and footer stuff at both places

Fixup total number of results. Job done!
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
——@@ -47,14 +47,10 @@
4848 $limitForm = $pager->getLimitForm();
4949
5050 $wgOut->addHTML(
51 - '<table><tr>' .
5251 $navBar .
53 - '</tr>' .
54 - '<tr><td>' .
55 - $limitForm .
56 - '</td><td style="padding-left: 2em;">' .
57 - '&#160;<strong>' . wfMsgHtml( 'code-rev-total', $revCount ) . '</strong>' .
58 - '</td></tr></table>' .
 52+ '<table><tr><td>' . $limitForm . '</td>' .
 53+ '<td>&#160;<strong>' . wfMsgHtml( 'code-rev-total', $revCount ) . '</strong></td>' .
 54+ '</tr></table>' .
5955 Xml::openElement( 'form',
6056 array( 'action' => $pager->getTitle()->getLocalURL(), 'method' => 'post' )
6157 ) .

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76849More of (bug 25899) Show header and footer stuff at both places...reedy23:30, 16 November 2010
r76853More of (bug 25899) Show header and footer stuff at both places...reedy23:36, 16 November 2010

Comments

#Comment by Nikerabbit (talk | contribs)   09:12, 17 November 2010

Why doesn't $revCount need to be escaped?

#Comment by Reedy (talk | contribs)   13:04, 17 November 2010

No idea, I didn't add it...

Status & tagging log