r76814 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76813‎ | r76814 | r76815 >
Date:18:28, 16 November 2010
Author:aaron
Status:ok
Tags:
Comment:
Moved /0 prefix tests to valid...it just means "everything"
Modified paths:
  • /trunk/phase3/maintenance/tests/phpunit/includes/IPTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/includes/IPTest.php
@@ -165,11 +165,13 @@
166166 '16.17.184.1/24',
167167 '30.242.52.14/1',
168168 '10.232.52.13/8',
 169+ '30.242.52.14/0',
169170 '::e:f:2001/96',
170171 '::c:f:2001/128',
171172 '::10:f:2001/70',
172173 '::fe:f:2001/1',
173174 '::6d:f:2001/8',
 175+ '::fe:f:2001/0',
174176 );
175177 foreach ( $valid as $i ) {
176178 $this->assertTrue( IP::isValidBlock( $i ), "$i is a valid IP block" );
@@ -182,14 +184,12 @@
183185 '116.17.184.5/33',
184186 '0.17.184.5/130',
185187 '16.17.184.1/-1',
186 - '30.242.52.14/0',
187188 '10.232.52.13/*',
188189 '7.232.52.13/ab',
189190 '11.232.52.13/',
190191 '::e:f:2001/129',
191192 '::c:f:2001/228',
192193 '::10:f:2001/-1',
193 - '::fe:f:2001/0',
194194 '::6d:f:2001/*',
195195 '::86:f:2001/ab',
196196 '::23:f:2001/',

Status & tagging log