r76792 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76791‎ | r76792 | r76793 >
Date:14:06, 16 November 2010
Author:reedy
Status:ok
Tags:
Comment:
Variablise $navigationBar

Add a couple of braces
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)
  • /trunk/phase3/includes/Pager.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Pager.php
@@ -937,7 +937,9 @@
938938 function getNavigationBar() {
939939 global $wgStylePath, $wgContLang;
940940
941 - if ( !$this->isNavigationBarShown() ) return '';
 941+ if ( !$this->isNavigationBarShown() ) {
 942+ return '';
 943+ }
942944
943945 $path = "$wgStylePath/common/images";
944946 $labels = array(
Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -42,9 +42,11 @@
4343 $this->batchForm = $wgUser->isAllowed( 'codereview-set-status' ) ||
4444 $wgUser->isAllowed( 'codereview-add-tag' );
4545
 46+ $navBar = $pager->getNavigationBar();
 47+
4648 $wgOut->addHTML(
4749 '<table><tr><td>' .
48 - $pager->getNavigationBar() .
 50+ $navBar .
4951 $pager->getLimitForm() .
5052 '</td><td style="padding-left: 2em;">' .
5153 '&#160;<strong>' . wfMsgHtml( 'code-rev-total', $revCount ) . '</strong>' .
@@ -53,7 +55,7 @@
5456 array( 'action' => $pager->getTitle()->getLocalURL(), 'method' => 'post' )
5557 ) .
5658 $pager->getBody() .
57 - $pager->getNavigationBar() .
 59+ $navBar .
5860 ( $this->batchForm ? $this->buildBatchInterface( $pager ) : "" ) .
5961 Xml::closeElement( 'form' )
6062 );

Status & tagging log