r76764 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76763‎ | r76764 | r76765 >
Date:03:23, 16 November 2010
Author:kaldari
Status:deferred
Tags:
Comment:
form formatting
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter3.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter3.php
@@ -56,14 +56,19 @@
5757 $form .= "<p class='creditcard-error-msg'>" . $this->form_errors['retryMsg'] . "</p>";
5858 $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'onsubmit' => 'return validate_form(this)', 'autocomplete' => 'off' ) );
5959
60 - $form .= $this->generateBillingContainer();
 60+ $form .= Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-personal-info' ) );
 61+ $form .= Xml::openElement( 'table', array( 'id' => 'payflow-table-donor' ) );
 62+ $form .= $this->generateBillingFields();
 63+
6164 return $form;
6265 }
6366
6467 public function generateFormSubmit() {
6568 global $wgScriptPath;
 69+
 70+ $form .= '<tr>';
 71+ $form .= '<td class="label"> </td>';
6672 // submit button
67 - $form = Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-form-submit' ) );
6873 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
6974 // $form .= Xml::submitButton( wfMsg( 'payflowpro_gateway-submit-button' ));
7075 $form .= Xml::element( 'input', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/submit-donation-button.png", 'alt' => 'Submit donation', 'onclick' => 'submit_form( this )', 'type' => 'image' ) );
@@ -71,24 +76,16 @@
7277 $form .= Xml::openElement( 'div', array( 'class' => 'mw-donate-submessage', 'id' => 'payflowpro_gateway-donate-submessage' ) ) .
7378 Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/padlock.gif", 'style' => 'vertical-align:baseline;margin-right:4px;' ) ) . 'Your credit / debit card will be securely processed.';
7479 $form .= Xml::closeElement( 'div' ); // close div#payflowpro_gateway-donate-submessage
75 - $form .= Xml::closeElement( 'div' ); // close div#payflowpro_gateway-form-submit
 80+
 81+ $form .= '</tr>';
7682 return $form;
7783 }
7884
7985 public function generateFormEnd() {
8086 $form = '';
81 - $form .= $this->generateFormClose();
82 - return $form;
83 - }
84 -
85 - protected function generateBillingContainer() {
86 - $form = '';
87 - $form .= Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-personal-info' ) );
88 - $form .= Xml::openElement( 'table', array( 'id' => 'payflow-table-donor' ) );
89 - $form .= $this->generateBillingFields();
9087 $form .= Xml::closeElement( 'table' ); // close table#payflow-table-donor
9188 $form .= Xml::closeElement( 'div' ); // close div#payflowpro_gateway-personal-info
92 -
 89+ $form .= $this->generateFormClose();
9390 return $form;
9491 }
9592
@@ -201,7 +198,7 @@
202199 $form .= '<td colspan=2><span class="creditcard-error-msg"> </span></td>';
203200 $form .= '</tr>';
204201 $form .= '<tr>';
205 - $form .= '<td class="label">' . Xml::label( wfMsg( 'payflowpro_gateway-donor-postal' ), 'zip' ) . '</td>';
 202+ $form .= '<td class="label"> </td>';
206203 $form .= '<td>' . Xml::input( 'zip', '30', $this->form_data['zip'], array( 'type' => 'text', 'maxlength' => '9', 'id' => 'zip', 'class' => 'fullwidth' ) ) .
207204 '</td>';
208205 $form .= '</tr>';

Status & tagging log