r76727 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76726‎ | r76727 | r76728 >
Date:22:53, 15 November 2010
Author:aaron
Status:deferred
Tags:
Comment:
Fixed annoying history highlighting bug
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php
@@ -1640,15 +1640,15 @@
16411641 if ( !$fa->isReviewable() ) {
16421642 return true; // nothing to do here
16431643 }
1644 - $title = $history->getArticle()->getTitle();
16451644 # Fetch and process cache the stable revision
16461645 if ( !isset( $history->fr_stableRevId ) ) {
16471646 $history->fr_stableRevId = $fa->getStable();
16481647 $history->fr_pendingRevs = false;
1649 - if ( !$history->fr_stableRevId ) {
1650 - return true; // nothing to do here
1651 - }
16521648 }
 1649+ if ( !$history->fr_stableRevId ) {
 1650+ return true; // nothing to do here
 1651+ }
 1652+ $title = $history->getArticle()->getTitle();
16531653 $revId = (int)$row->rev_id;
16541654 // Pending revision: highlight and add diff link
16551655 $link = $class = '';

Status & tagging log