r76692 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r76691‎ \| r76692 \| r76693 >
Date:	18:09, 15 November 2010
Author:	demon
Status:	ok
Tags:
Comment:	First followup to r75408, sanity check on result object
Modified paths:	/trunk/extensions/FlaggedRevs/forms/RevisionReviewForm.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/forms/RevisionReviewForm.php
—	—	@@ -1007,8 +1007,10 @@
1008	1008	);
1009	1009
1010	1010	$ids = array();
1011		~~- foreach( $res as $r ) {~~
1012		~~- $ids[] = $r->rev_id;~~
	1011	+ if( $res ) {
	1012	+ foreach( $res as $r ) {
	1013	+ $ids[] = $r->rev_id;
	1014	+ }
1013	1015	}
1014	1016
1015	1017	// List of revisions being undone...

Follow-up revisions

Revision	Commit summary	Author	Date
r76968	Follow-up r76692: just redirect out in this very unlikely case (rather than f...	aaron	21:45, 18 November 2010

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r75408	(bug 25294) "Reject" button confirmation screen in Pending Change	demon	02:36, 26 October 2010

Status & tagging log

21:33, 18 November 2010 Aaron Schulz (talk | contribs) changed the status of r76692 [removed: new added: ok]