r76690 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76689‎ | r76690 | r76691 >
Date:17:58, 15 November 2010
Author:maxsem
Status:ok
Tags:
Comment:
Extensions cleanup: deprecated features, missing semicolon, duplicate constructor
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/extras/minfraud/tests/minfraudTest.php (modified) (history)
  • /trunk/extensions/DoubleWiki/DoubleWiki_body.php (modified) (history)
  • /trunk/extensions/ExtensionDistributor/svn-invoker.php (modified) (history)
  • /trunk/extensions/GroupsSidebar/GroupsSidebar.body.php (modified) (history)
  • /trunk/extensions/InlineEditor/InlineEditorNode.class.php (modified) (history)
  • /trunk/extensions/InlineEditor/InlineEditorText.class.php (modified) (history)
  • /trunk/extensions/MiniPreview/MiniPreview.php (modified) (history)
  • /trunk/extensions/MwEmbed/MwEmbed/modules/ApiEmbed/ApiEmbed.resourceList.php (modified) (history)
  • /trunk/extensions/RdfRedland/test/includes/Article.php (modified) (history)
  • /trunk/extensions/WebDAV/WebDavServer.php (modified) (history)
  • /trunk/extensions/uniwiki/CustomToolbar/CustomToolbar.php (modified) (history)

Diff [purge]

Index: trunk/extensions/uniwiki/CustomToolbar/CustomToolbar.php
@@ -125,7 +125,7 @@
126126 $this->mType = $request->getVal('type');
127127 $this->mCaption = $request->getText('wpCaption');
128128 $this->mSection = $request->getVal('section');
129 - UploadForm::UploadForm(&$request);
 129+ UploadForm::UploadForm($request);
130130 }
131131
132132 function execute() {
Index: trunk/extensions/RdfRedland/test/includes/Article.php
@@ -51,10 +51,6 @@
5252 }
5353 }
5454
55 - public function Article( $title ) {
56 - $this->__construct( $title );
57 - }
58 -
5955 public function getContent() {
6056 return $this->content;
6157 }
Index: trunk/extensions/InlineEditor/InlineEditorText.class.php
@@ -296,7 +296,7 @@
297297 */
298298 protected function buildTree( array $markingsSorted ) {
299299 // create the root
300 - $root = new InlineEditorRoot( &$this->wikiOriginal );
 300+ $root = new InlineEditorRoot( $this->wikiOriginal );
301301
302302 // $workingNode is the node we're trying to add children to
303303 // init it to the root node
@@ -304,7 +304,7 @@
305305
306306 foreach( $markingsSorted as $marking ) {
307307 // create a new node for this marking
308 - $node = new InlineEditorNode( &$this->wikiOriginal, $marking );
 308+ $node = new InlineEditorNode( $this->wikiOriginal, $marking );
309309
310310 // keep trying to add $node to $workingNode, move a level up if it fails
311311 while( true )
Index: trunk/extensions/InlineEditor/InlineEditorNode.class.php
@@ -12,7 +12,7 @@
1313 * @param $marking InlineEditorMarking Marking to wrap in the tree
1414 */
1515 public function __construct( &$wiki, InlineEditorMarking $marking ) {
16 - parent::__construct( &$wiki );
 16+ parent::__construct( $wiki );
1717 $this->marking = $marking;
1818 }
1919
Index: trunk/extensions/WebDAV/WebDavServer.php
@@ -18,7 +18,7 @@
1919 }
2020
2121 function options( &$serverOptions ) {
22 - parent::options( &$serverOptions );
 22+ parent::options( $serverOptions );
2323
2424 if ( $serverOptions['xpath']->evaluate( 'boolean(/D:options/D:activity-collection-set)' ) ) {
2525 $this->setResponseHeader( 'Content-Type: text/xml; charset="utf-8"' );
Index: trunk/extensions/ExtensionDistributor/svn-invoker.php
@@ -74,7 +74,7 @@
7575 $dir = "$wgExtDistWorkingCopy/$version/extensions/$extension";
7676
7777 // Determine last changed revision in the checkout
78 - $localRev = svnGetRev( $dir, &$remoteDir );
 78+ $localRev = svnGetRev( $dir, $remoteDir );
7979 if ( !$localRev ) {
8080 return;
8181 }
Index: trunk/extensions/DonationInterface/payflowpro_gateway/extras/minfraud/tests/minfraudTest.php
@@ -184,11 +184,11 @@
185185 'num_attempt' => 2
186186 );
187187 // @fixme this needs updating
188 - // $this->assertTrue( $this->fixture->can_bypass_minfraud( &$this->fixture, &$data ));
 188+ // $this->assertTrue( $this->fixture->can_bypass_minfraud( $this->fixture, $data ));
189189 // $this->assertEquals( 'challenge', $this->fixture->action );
190190 // $this->assertEquals( '029ef6f5c2a165215b5a92ff1a194e4a6de8c668d6193582da42713f119c1b07d8358b5cd94a3bd51c9aa50709c8533295215ce3cce8c2b61e69078d789bc3f3', $data[ 'data_hash' ]);
191191
192192 $data[] = 'bar';
193 - $this->assertFalse( $this->fixture->can_bypass_minfraud( &$this->fixture, &$data ) );
 193+ $this->assertFalse( $this->fixture->can_bypass_minfraud( $this->fixture, $data ) );
194194 }
195195 }
Index: trunk/extensions/MwEmbed/MwEmbed/modules/ApiEmbed/ApiEmbed.resourceList.php
@@ -7,4 +7,4 @@
88 'ApiEmbed' => array(
99 'loader' => array() // @@FIXME add in apiSupport
1010 )
11 -)
\ No newline at end of file
 11+);
\ No newline at end of file
Index: trunk/extensions/MiniPreview/MiniPreview.php
@@ -113,7 +113,7 @@
114114 if ( $p->entry[1]->id != 0 ) $image_titles[$p->entry[1]->title] = $p->entry[1]->title ;
115115 }
116116 $image_data = array();
117 - wfMiniPreviewGetImageData ( $image_titles , &$image_data ) ;
 117+ wfMiniPreviewGetImageData ( $image_titles , $image_data ) ;
118118
119119 # Output
120120 $mainwidth = ( $wgMiniPreviewThumbnailSize + 2 ) * 3 ;
Index: trunk/extensions/DoubleWiki/DoubleWiki_body.php
@@ -58,7 +58,7 @@
5959 if ( $match_request === '' ) {
6060 return true;
6161 }
62 - $this->addMatchingTags ( &$text, $match_request );
 62+ $this->addMatchingTags ( $text, $match_request );
6363
6464 foreach( $parserOutput->mLanguageLinks as $l ) {
6565 $nt = Title::newFromText( $l );
Index: trunk/extensions/GroupsSidebar/GroupsSidebar.body.php
@@ -11,7 +11,7 @@
1212 # addToSidebar currently won't throw errors if we call it
1313 # with nonexisting pages, but better check and be sure
1414 if ( Title::newFromText( $message, NS_MEDIAWIKI )->exists() )
15 - $skin->addToSidebar( &$bar, $message );
 15+ $skin->addToSidebar( $bar, $message );
1616 }
1717 return true;
1818 }

Status & tagging log