r76650 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76649‎ | r76650 | r76651 >
Date:23:20, 13 November 2010
Author:nad
Status:deferred
Tags:
Comment:
dont escape values when moving from record form to edit form
Modified paths:
  • /trunk/extensions/RecordAdmin/RecordAdmin.php (modified) (history)
  • /trunk/extensions/RecordAdmin/RecordAdmin_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RecordAdmin/RecordAdmin_body.php
@@ -115,7 +115,7 @@
116116 hidden = document.createElement( 'input' );
117117 hidden.setAttribute( 'name', key );
118118 hidden.setAttribute( 'type', 'hidden' );
119 - hidden.value = escape( input.value );
 119+ hidden.value = input.value;
120120 document.getElementById( 'editform' ).appendChild( hidden );
121121 }
122122 }
Index: trunk/extensions/RecordAdmin/RecordAdmin.php
@@ -1,5 +1,5 @@
22 <?php
3 -if ( !defined( 'MEDIAWIKI' ) ) die( 'Not an entry point.' );
 3+if( !defined( 'MEDIAWIKI' ) ) die( 'Not an entry point.' );
44 /**
55 * Extension:RecordAdmin - MediaWiki extension
66 *
@@ -10,7 +10,7 @@
1111 * @author Siebrand Mazeland
1212 * @licence GNU General Public Licence 2.0 or later
1313 */
14 -define( 'RECORDADMIN_VERSION', '1.1.0, 2010-09-21' );
 14+define( 'RECORDADMIN_VERSION', '1.1.2, 2010-11-14' );
1515
1616 $dir = dirname( __FILE__ ) . '/';
1717 $wgExtensionMessagesFiles['RecordAdmin'] = $dir . 'RecordAdmin.i18n.php';

Status & tagging log