r76580 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76579‎ | r76580 | r76581 >
Date:16:38, 12 November 2010
Author:ialex
Status:deferred
Tags:
Comment:
Let just return false instead of a WikiError since the return value is not checked
Modified paths:
  • /trunk/extensions/MetavidWiki/includes/specials/MV_SpecialExport.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MetavidWiki/includes/specials/MV_SpecialExport.php
@@ -450,7 +450,7 @@
451451 global $wgSitename, $wgTitle, $wgRequest;
452452 // check for semantic wiki:
453453 if ( !defined( 'SMW_VERSION' ) ) {
454 - return new WikiError( "Export Ask is dependent on semantic media wiki" );
 454+ return false;
455455 }
456456 // bootstrap off of SMWAskPage:
457457 $SMWAskPage = new SMWAskPage();

Status & tagging log