r76575 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76574‎ | r76575 | r76576 >
Date:14:20, 12 November 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Followup r76566

HttpFunctions.old.php had the same definition twice
Modified paths:
  • /trunk/phase3/includes/HttpFunctions.old.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HttpFunctions.old.php
@@ -10,15 +10,3 @@
1111 */
1212
1313 class HttpRequest extends MWHttpRequest { }
14 -<?php
15 -
16 -/**
17 - * HttpRequest was renamed to MWHttpRequest in order
18 - * to prevent conflicts with PHP's HTTP extension
19 - * which also defines an HttpRequest class.
20 - * http://www.php.net/manual/en/class.httprequest.php
21 - *
22 - * This is for backwards compatibility.
23 - */
24 -
25 -class HttpRequest extends MWHttpRequest { }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76566(Bug 25872) Rename HttpRequest class to MWHttpRequest to avoid conflict with ...bawolff07:32, 12 November 2010

Comments

#Comment by Bawolff (talk | contribs)   18:14, 12 November 2010

Sorry about that. Not sure how I managed to do that.

Status & tagging log