r76540 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76539‎ | r76540 | r76541 >
Date:20:03, 11 November 2010
Author:overlordq
Status:ok
Tags:
Comment:
Partial 'reverts' of of r70608, r76539, that doesn't do what you want, you're specifying the same rc_id for every row which is wrong
Modified paths:
  • /trunk/phase3/maintenance/rebuildrecentchanges.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/rebuildrecentchanges.php
@@ -66,7 +66,6 @@
6767 $cutoff = time() - $wgRCMaxAge;
6868 $dbw->insertSelect( 'recentchanges', array( 'page', 'revision' ),
6969 array(
70 - 'rc_id' => ( $dbw->nextSequenceValue( 'recentchanges_rc_id_seq' ) > 0 ) ? $dbw->nextSequenceValue( 'recentchanges_rc_id_seq' ) : 0,
7170 'rc_timestamp' => 'rev_timestamp',
7271 'rc_cur_time' => 'rev_timestamp',
7372 'rc_user' => 'rev_user',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70608DatabaseMssql class and related changesyaauie23:44, 6 August 2010
r76539sequence was renamed a while back but this was missedoverlordq19:53, 11 November 2010

Status & tagging log