r76504 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76503‎ | r76504 | r76505 >
Date:04:52, 11 November 2010
Author:kaldari
Status:deferred
Tags:
Comment:
trying to fix bug 25883
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/Form.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php
@@ -405,7 +405,7 @@
406406 'ZIP' => $data['zip'],
407407 'INVNUM' => $data['order_id'],
408408 'CVV2' => $data['cvv'],
409 - 'CURRENCY' => $data['currency'],
 409+ 'CURRENCY' => $data['currency_code'],
410410 'VERBOSITY' => $payflow_data['verbosity'],
411411 'CUSTIP' => $payflow_data['user_ip'],
412412 );
@@ -1001,7 +1001,7 @@
10021002 'card_num' => $card_nums[ $cards[ $card_index ]][ $card_num_index ],
10031003 'expiration' => date( 'my', strtotime( '+1 year 1 month' ) ),
10041004 'cvv' => '001',
1005 - 'currency' => 'USD',
 1005+ 'currency_code' => 'USD',
10061006 'payment_method' => $wgRequest->getText( 'payment_method' ),
10071007 'order_id' => $order_id,
10081008 'numAttempt' => $numAttempt,
@@ -1039,7 +1039,7 @@
10401040 'card_num' => str_replace( ' ', '', $wgRequest->getText( 'card_num' ) ),
10411041 'expiration' => $wgRequest->getText( 'mos' ) . substr( $wgRequest->getText( 'year' ), 2, 2 ),
10421042 'cvv' => $wgRequest->getText( 'cvv' ),
1043 - 'currency' => $wgRequest->getText( 'currency_code' ),
 1043+ 'currency_code' => $wgRequest->getText( 'currency_code' ),
10441044 'payment_method' => $wgRequest->getText( 'payment_method' ),
10451045 'order_id' => $order_id,
10461046 'numAttempt' => $numAttempt,
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/Form.php
@@ -319,7 +319,7 @@
320320
321321 // generate dropdown of currency opts
322322 foreach ( $available_currencies as $value => $currency_name ) {
323 - $selected = ( $this->form_data[ 'currency' ] == $value ) ? true : false;
 323+ $selected = ( $this->form_data[ 'currency_code' ] == $value ) ? true : false;
324324 $currency_opts .= Xml::option( wfMsg( 'donate_interface-' . $value ), $value, $selected );
325325 }
326326

Follow-up revisions

RevisionCommit summaryAuthorDate
r76505trying to fix bug 25883kaldari05:02, 11 November 2010
r76507final fix for bug 25883kaldari05:19, 11 November 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76498trying to fix bug 25883kaldari04:31, 11 November 2010
r76499trying to fix bug 25883kaldari04:33, 11 November 2010
r76501trying to fix bug 25883kaldari04:41, 11 November 2010

Status & tagging log