r76436 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76435‎ | r76436 | r76437 >
Date:08:28, 10 November 2010
Author:ialex
Status:ok
Tags:
Comment:
Fix for r70871: need explicit check against null since current check also catches "0", thus making an infinite redirect loop for that article
Modified paths:
  • /trunk/phase3/includes/Wiki.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Wiki.php
@@ -211,7 +211,7 @@
212212 }
213213 // Redirect loops, no title in URL, $wgUsePathInfo URLs, and URLs with a variant
214214 } else if ( $action == 'view' && !$request->wasPosted()
215 - && ( !$request->getVal( 'title' ) || $title->getPrefixedDBKey() != $request->getText( 'title' ) )
 215+ && ( $request->getVal( 'title' ) === null || $title->getPrefixedDBKey() != $request->getText( 'title' ) )
216216 && !count( array_diff( array_keys( $request->getValues() ), array( 'action', 'title' ) ) ) )
217217 {
218218 if ( $title->getNamespace() == NS_SPECIAL ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70871Remove raw $_GET usage held over from days before WebRequest existed, was int...demon12:15, 11 August 2010

Status & tagging log