r76398 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76397‎ | r76398 | r76399 >
Date:17:46, 9 November 2010
Author:yaron
Status:deferred
Tags:
Comment:
Added check to ignore blank values for "show on select"
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormPrinter.php
@@ -573,6 +573,8 @@
574574 // html_entity_decode() is needed to turn '>' to '>'
575575 $vals = explode( ';', html_entity_decode( $sub_components[1] ) );
576576 foreach ( $vals as $val ) {
 577+ $val = trim( $val );
 578+ if ( empty( $val ) ) continue;
577579 $option_div_pair = explode( '=>', $val, 2 );
578580 if ( count( $option_div_pair ) > 1 ) {
579581 $option = $option_div_pair[0];

Status & tagging log