r76360 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76359‎ | r76360 | r76361 >
Date:00:37, 9 November 2010
Author:pdhanda
Status:ok
Tags:
Comment:
Reusing existing class, mw-small-spinner. Followup to r75331
Modified paths:
  • /trunk/extensions/FlaggedRevs/client/flaggedrevs.css (modified) (history)
  • /trunk/extensions/FlaggedRevs/client/flaggedrevs.js (modified) (history)
  • /trunk/extensions/FlaggedRevs/client/img/loading-small.gif (deleted) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/client/flaggedrevs.css
@@ -333,14 +333,12 @@
334334 .loading {
335335 display: block;
336336 color: #666666;
337 - padding-left: 32px;
 337+ padding-left: 40px;
338338 height: 32px;
339339 }
340340 .spinner {
341 - background-image: url(img/loading-small.gif) !important;
342341 background-position: left center;
343 - background-repeat: no-repeat;
344 - margin-left: 0.5em;
345 - margin-top: -0.25em;
 342+ margin-left: 1em;
 343+ margin-top: -1.3em;
346344 float: left;
347345 }
Index: trunk/extensions/FlaggedRevs/client/flaggedrevs.js
@@ -192,7 +192,7 @@
193193 var diffUIParams = document.getElementById("mw-fr-diff-dataform");
194194 var oldRevId = diffUIParams.getElementsByTagName('input')[1].value;
195195 var origContents = contentsDiv.innerHTML;
196 - contentsDiv.innerHTML = "<span class='loading spinner'></span><span class='loading' >" + wgRevContents.waiting + "</span>";
 196+ contentsDiv.innerHTML = "<span class='loading mw-small-spinner spinner'></span><span class='loading' >" + wgRevContents.waiting + "</span>";
197197 var requestArgs = 'action=parse&prop=text&format=xml';
198198 if ( window.wgLatestRevisionId == oldRevId ) {
199199 requestArgs += '&pageid=' + window.wgPageId;
Index: trunk/extensions/FlaggedRevs/client/img/loading-small.gif
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75331bug25289 Changes to make revisions with pending changes not load content imme...pdhanda18:48, 24 October 2010

Status & tagging log