r76309 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r76308‎ | r76309 | r76310 >
Date:15:23, 8 November 2010
Author:catrope
Status:ok
Tags:
Comment:
(bug 25839) Set class="blockExpiry" and dir="ltr" (bug suggested direction: ltr; in CSS, but that doesn't work in this case) on the <span> containing the block expiry in Special:Log. It seems strange to unconditionally set dir="ltr" on something that may contain text in an RTL language, but it seems to leave the latter alone while fixing the display of ISO 8601 timestamps. It's definitely possible there's another issue with dir="ltr" that I overlooked here, so if this does break display of other expiries in RTL, please revert.
Modified paths:
  • /trunk/phase3/includes/LogPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogPage.php
——@@ -233,7 +233,7 @@
234234 // User suppression
235235 if ( preg_match( '/^(block|suppress)\/(block|reblock)$/', $key ) ) {
236236 if ( $skin ) {
237 - $params[1] = '<span title="' . htmlspecialchars( $params[1] ). '">' .
 237+ $params[1] = '<span class="blockExpiry" dir="ltr" title="' . htmlspecialchars( $params[1] ). '">' .
238238 $wgLang->translateBlockExpiry( $params[1] ) . '</span>';
239239 } else {
240240 $params[1] = $wgContLang->translateBlockExpiry( $params[1] );

Status & tagging log