r76307 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76306‎ | r76307 | r76308 >
Date:15:14, 8 November 2010
Author:hartman
Status:ok
Tags:
Comment:
Followup r76303. Use a less verbose const VERSION.
Modified paths:
  • /trunk/phase3/includes/filerepo/ForeignAPIRepo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/ForeignAPIRepo.php
@@ -25,7 +25,7 @@
2626 /* This version string is used in the user agent for requests and will help
2727 * server maintainers in identify ForeignAPI usage.
2828 * Update the version every time you make breaking or significant changes. */
29 - public static $foreignAPIRepoVersion = "2.0";
 29+ const VERSION = "2.0";
3030
3131 var $fileFactory = array( 'ForeignAPIFile', 'newFromTitle' );
3232 /* Check back with Commons after a day */
@@ -344,7 +344,7 @@
345345 * The user agent the ForeignAPIRepo will use.
346346 */
347347 public static function getUserAgent() {
348 - return Http::userAgent() . " ForeignAPIRepo/" . self::$foreignAPIRepoVersion;
 348+ return Http::userAgent() . " ForeignAPIRepo/" . self::VERSION;
349349 }
350350
351351 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76303Add a version number and user-agent string to ForeignAPIRepo....hartman14:39, 8 November 2010

Status & tagging log