r76262 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76261‎ | r76262 | r76263 >
Date:18:59, 7 November 2010
Author:ialex
Status:ok (Comments)
Tags:
Comment:
* (bug 25713) SpecialPage::resolveAlias() now normalise spaces to underscores
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialPage.php
@@ -272,6 +272,7 @@
273273 if ( !self::$mListInitialised ) self::initList();
274274 if ( is_null( self::$mAliases ) ) self::initAliasList();
275275 $caseFoldedAlias = $wgContLang->caseFold( $alias );
 276+ $caseFoldedAlias = str_replace( ' ', '_', $caseFoldedAlias );
276277 if ( isset( self::$mAliases[$caseFoldedAlias] ) ) {
277278 return self::$mAliases[$caseFoldedAlias];
278279 } else {
Index: trunk/phase3/RELEASE-NOTES
@@ -402,6 +402,7 @@
403403 * (bug 25488) Disallowing anonymous users to read pages no longer throws error
404404 on discussion pages with vector as default skin
405405 * (bug 24833) Files name in includes/diff/ are now less confusing
 406+* (bug 25713) SpecialPage::resolveAlias() now normalise spaces to underscores
406407
407408 === API changes in 1.17 ===
408409 * (bug 22738) Allow filtering by action type on query=logevent.

Comments

#Comment by Happy-melon (talk | contribs)   23:47, 14 December 2010

For reference, the problem was that

{{#special:Alias With Spaces}}

would not resolve ("no such special page"), while

{{#special:Alias_With_Spaces}}

would resolve correctly.

Status & tagging log