r76258 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76257‎ | r76258 | r76259 >
Date:18:38, 7 November 2010
Author:ialex
Status:deferred
Tags:
Comment:
Set $ok at the beginning of the function; this variable is missing is case of failure in setupDatabase()
Modified paths:
  • /trunk/phase3/maintenance/tests/parser/parserTest.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/parser/parserTest.inc
@@ -337,6 +337,7 @@
338338 * @return Boolean: true if passed all tests, false if any tests failed.
339339 */
340340 public function runTestsFromFiles( $filenames ) {
 341+ $ok = false;
341342 $GLOBALS['wgContLang'] = Language::factory( 'en' );
342343 $this->recorder->start();
343344 try {

Status & tagging log