r76249 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76248‎ | r76249 | r76250 >
Date:14:50, 7 November 2010
Author:yaron
Status:deferred
Tags:
Comment:
Changed loading of jQuery and jQuery UI modules to be done as 'dependencies' of SF modules, which makes combobox behavior work more consistently
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_Utils.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_Utils.php
@@ -119,6 +119,10 @@
120120 'skins/SemanticForms.css',
121121 'skins/SF_jquery_ui_overrides.css',
122122 ),
 123+ 'dependencies' => array(
 124+ 'jquery.ui.autocomplete',
 125+ 'jquery.ui.button'
 126+ ),
123127 ), $localpath, $remotepath
124128 ),
125129 'ext.semanticforms.fancybox' => new ResourceLoaderFileModule(
@@ -144,9 +148,6 @@
145149 */
146150 static function loadJavascriptAndCSS() {
147151 global $wgOut;
148 - $wgOut->addModules( 'jquery' );
149 - $wgOut->addModules( 'jquery.ui.autocomplete' );
150 - $wgOut->addModules( 'jquery.ui.button' );
151152 $wgOut->addModules( 'ext.semanticforms.main' );
152153 $wgOut->addModules( 'ext.semanticforms.fancybox' );
153154 $wgOut->addModules( 'ext.semanticforms.autogrow' );

Status & tagging log