r76241 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76240‎ | r76241 | r76242 >
Date:11:37, 7 November 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Convert some spammy wfWarns to error_log
Modified paths:
  • /trunk/extensions/Translate/utils/TranslationHelpers.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/TranslationHelpers.php
@@ -365,15 +365,13 @@
366366 $response = FormatJson::decode( $json );
367367
368368 if ( $json === false ) {
369 - wfWarn( __METHOD__ . ': Http::get failed' );
 369+ error_log( __METHOD__ . ': Http::get failed' );
370370 // Most likely a timeout or other general error
371371 self::reportTranslationServiceFailure( $serviceName );
372372
373373 return null;
374374 } elseif ( !is_object( $response ) ) {
375 - wfWarn( __METHOD__ . ': Unable to parse reply: ' . strval( $json ) );
376375 error_log( __METHOD__ . ': Unable to parse reply: ' . strval( $json ) );
377 -
378376 return null;
379377 }
380378
@@ -462,7 +460,7 @@
463461 return null;
464462 }
465463
466 - wfWarn( __METHOD__ . ': Http::get failed:' . $error );
 464+ error_log( __METHOD__ . ': Http::get failed:' . $error );
467465 // Most likely a timeout or other general error
468466 self::reportTranslationServiceFailure( $serviceName );
469467 return null;

Status & tagging log