r76239 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76238‎ | r76239 | r76240 >
Date:11:11, 7 November 2010
Author:ialex
Status:ok
Tags:
Comment:
* (bug 25488) Disallowing anonymous users to read pages no longer throws error on discussion pages with vector as default skin
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -140,7 +140,7 @@
141141 );
142142 // Checks if this is a current rev of talk page and we should show a new
143143 // section link
144 - if ( ( $isTalk && $wgArticle->isCurrent() ) || ( $wgOut->showNewSectionLink() ) ) {
 144+ if ( ( $isTalk && $wgArticle && $wgArticle->isCurrent() ) || ( $wgOut->showNewSectionLink() ) ) {
145145 // Checks if we should ever show a new section link
146146 if ( !$wgOut->forceHideNewSectionLink() ) {
147147 // Adds new section link
Index: trunk/phase3/RELEASE-NOTES
@@ -399,6 +399,8 @@
400400 * (bug 19129) Only show MyISAM/InnoDB when supported
401401 * (bug 17762) Only show other e-mail options when e-mail is globally enabled
402402 * Cache multiple sizes of InstantCommons thumbnails
 403+* (bug 25488) Disallowing anonymous users to read pages no longer throws error
 404+ on discussion pages with vector as default skin
403405
404406 === API changes in 1.17 ===
405407 * (bug 22738) Allow filtering by action type on query=logevent.

Status & tagging log