r76153 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76152‎ | r76153 | r76154 >
Date:22:29, 5 November 2010
Author:platonides
Status:ok
Tags:
Comment:
Follow up r76138. Globals that are now unneeded.
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -2296,7 +2296,7 @@
22972297
22982298 // TODO: Document
22992299 protected function makeResourceLoaderLink( $skin, $modules, $only, $useESI = false ) {
2300 - global $wgUser, $wgLang, $wgRequest, $wgLoadScript, $wgResourceLoaderDebug, $wgResourceLoaderUseESI,
 2300+ global $wgUser, $wgLang, $wgLoadScript, $wgResourceLoaderUseESI,
23012301 $wgResourceLoaderInlinePrivateModules;
23022302 // Lazy-load ResourceLoader
23032303 if ( is_null( $this->mResourceLoader ) ) {
@@ -2393,7 +2393,7 @@
23942394 * @return String: HTML fragment
23952395 */
23962396 function getHeadScripts( Skin $sk ) {
2397 - global $wgUser, $wgRequest, $wgUseSiteJs, $wgResourceLoaderDebug;
 2397+ global $wgUser, $wgRequest, $wgUseSiteJs;
23982398
23992399 // Startup - this will immediately load jquery and mediawiki modules
24002400 $scripts = $this->makeResourceLoaderLink( $sk, 'startup', 'scripts', true );
@@ -2501,7 +2501,7 @@
25022502 * @return string HTML tag links to be put in the header.
25032503 */
25042504 public function getHeadLinks( $sk ) {
2505 - global $wgFeed, $wgRequest, $wgResourceLoaderDebug;
 2505+ global $wgFeed;
25062506
25072507 // Ideally this should happen earlier, somewhere. :P
25082508 $this->addDefaultMeta();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76138Followup r75825: per bug 25610 comment #3, check for debug mode in all other ...catrope20:36, 5 November 2010

Status & tagging log