r76148 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76147‎ | r76148 | r76149 >
Date:22:10, 5 November 2010
Author:platonides
Status:ok
Tags:
Comment:
Unneeded globals. Require for EDIT_TOKEN_SUFFIX.
Modified paths:
  • /trunk/phase3/maintenance/tests/phpunit/includes/api/ApiUploadTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/includes/api/ApiUploadTest.php
@@ -18,6 +18,7 @@
1919 // TODO: port the other Upload tests, and other API tests to this framework
2020
2121 require_once( dirname( __FILE__ ) . '/RandomImageGenerator.php' );
 22+require_once( dirname( __FILE__ ) . '/../../../../../includes/User.php' );
2223
2324 /* Wraps the user object, so we can also retain full access to properties like password if we log in via the API */
2425 class ApiTestUser {
@@ -28,8 +29,6 @@
2930 public $user;
3031
3132 function __construct( $username, $realname = 'Real Name', $email = 'sample@sample.com', $groups = array() ) {
32 - global $wgMinimalPasswordLength;
33 -
3433 $this->username = $username;
3534 $this->realname = $realname;
3635 $this->email = $email;
@@ -83,7 +82,7 @@
8483 public static $users;
8584
8685 function setUp() {
87 - global $wgServer, $wgContLang, $wgAuth, $wgMemc, $wgRequest, $wgUser;
 86+ global $wgContLang, $wgAuth, $wgMemc, $wgRequest, $wgUser;
8887
8988 $wgMemc = new FakeMemCachedClient();
9089 $wgContLang = Language::factory( 'en' );

Status & tagging log