r76146 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76145‎ | r76146 | r76147 >
Date:21:52, 5 November 2010
Author:hashar
Status:ok
Tags:
Comment:
show a dash when there is no comment for a revision

The long list of 0 make it less clear. I also centered the text.
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.php (modified) (history)
  • /trunk/extensions/CodeReview/codereview.css (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.php
@@ -124,7 +124,7 @@
125125 $wgCodeReviewImportBatchSize = 400;
126126
127127 // Bump the version number every time you change a CodeReview .css/.js file
128 -$wgCodeReviewStyleVersion = 6;
 128+$wgCodeReviewStyleVersion = 7;
129129
130130 // The name of a repo which represents the code running on this wiki, used to highlight active revisions
131131 $wgWikiSVN = '';
Index: trunk/extensions/CodeReview/codereview.css
@@ -7,6 +7,9 @@
88 overflow:auto;
99 }
1010
 11+.TablePager_col_comments {
 12+ text-align: center;
 13+}
1114 .TablePager_col_cr_message {
1215 max-width: 20em;
1316 }
Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -332,7 +332,7 @@
333333 $special->setFragment( '#code-comments' );
334334 return $this->mView->mSkin->link( $special, htmlspecialchars( $value ) );
335335 } else {
336 - return intval( $value );
 336+ return '-';
337337 }
338338 case 'cr_path':
339339 return Xml::openElement( 'div', array( 'title' => (string)$value ) ) .

Status & tagging log