r76135 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76134‎ | r76135 | r76136 >
Date:20:14, 5 November 2010
Author:tomasz
Status:ok
Tags:
Comment:
Picking udp2log stats fix for meta
Modified paths:
  • /branches/wmf/1.16wmf4/extensions/CentralNotice (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/CentralNotice/SpecialBannerController.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/extensions/CentralNotice/SpecialBannerController.php
@@ -55,7 +55,8 @@
5656 'fn': {
5757 'loadBanner': function( bannerName ) {
5858 // Get the requested banner
59 - var bannerPage = 'Special:BannerLoader?banner='+bannerName+'&userlang='+wgUserLanguage+'&db='+wgDBname+'&sitename='+wgSiteName+'&country='+Geo.country;
 59+ var bannerPageQuery = $.param( { 'banner': bannerName, 'userlang': wgUserLanguage, 'db': wgDBname, 'sitename': wgSiteName, 'country': Geo.country } );
 60+ var bannerPage = '?title=Special:BannerLoader&' + bannerPageQuery;
6061 EOT;
6162 $js .= "\n\t\t\t\tvar bannerScript = '<script type=\"text/javascript\" src=\"".Xml::escapeJsString( $wgCentralPagePath )."' + bannerPage + '\"></script>';\n";
6263 $js .= <<<EOT
Property changes on: branches/wmf/1.16wmf4/extensions/CentralNotice
___________________________________________________________________
Modified: svn:mergeinfo
6364 Merged /trunk/extensions/CentralNotice:r75849

Status & tagging log