r76091 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76090‎ | r76091 | r76092 >
Date:13:37, 5 November 2010
Author:demon
Status:ok
Tags:
Comment:
Followup r76088: in the case where we can't read screen.css, output a comment in the CSS rather than serving nothing. Cleanup path so it outputs nicer without ..'s
Modified paths:
  • /trunk/phase3/includes/installer/WebInstallerOutput.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstallerOutput.php
@@ -85,12 +85,13 @@
8686 * @return String
8787 */
8888 public function getCSS( $dir ) {
89 - $vectorCssFile = dirname( __FILE__ ) . '/../../skins/vector/screen.css';
 89+ $vectorCssFile = dirname( dirname( dirname( __FILE__ ) ) ) .
 90+ '/skins/vector/screen.css';
9091 wfSuppressWarnings();
9192 $css = file_get_contents( $vectorCssFile );
9293 wfRestoreWarnings();
9394 if( !$css ) {
94 - return '';
 95+ return '/** Your webserver cannot read ' . $vectorCssFile . ', please check file permissions */';
9596 } elseif( $dir == 'rtl' ) {
9697 return CSSJanus::transform( $css, true );
9798 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76088Dynamically generate CSS (using vector now). Handles RTL/LTR flip properly \o...demon13:14, 5 November 2010

Status & tagging log