r76070 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76069‎ | r76070 | r76071 >
Date:01:42, 5 November 2010
Author:hartman
Status:reverted (Comments)
Tags:
Comment:
Add width to the cache key for thumburls in InstantCommons. No point in not caching multiple sizes if we can, must have been an oversight.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/filerepo/ForeignAPIRepo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/ForeignAPIRepo.php
@@ -200,7 +200,7 @@
201201 return $this->getThumbUrl( $name, $width, $height );
202202 }
203203
204 - $key = $this->getLocalCacheKey( 'ForeignAPIRepo', 'ThumbUrl', $name );
 204+ $key = $this->getLocalCacheKey( 'ForeignAPIRepo', 'ThumbUrl', $name, $width );
205205 $thumbUrl = $wgMemc->get($key);
206206 if ( $thumbUrl ) {
207207 wfDebug("Got thumb from local cache. $thumbUrl \n");
Index: trunk/phase3/RELEASE-NOTES
@@ -396,6 +396,7 @@
397397 * (bug 16902) Installer spews warnings when exec() and dl() are not available
398398 * (bug 19129) Only show MyISAM/InnoDB when supported
399399 * (bug 17762) Only show other e-mail options when e-mail is globally enabled
 400+* Cache multiple sizes of InstantCommons thumbnails
400401
401402 === API changes in 1.17 ===
402403 * (bug 22738) Allow filtering by action type on query=logevent.

Follow-up revisions

RevisionCommit summaryAuthorDate
r76306Reverts r76070, which was breaking purging. Now caching the thumburls with ke...hartman15:05, 8 November 2010

Comments

#Comment by TheDJ (talk | contribs)   16:39, 5 November 2010

This breaks purgeThumbnails() in ForeignAPIFile.php

Is there a memcached wizard in the room ?

Status & tagging log