r76062 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76061‎ | r76062 | r76063 >
Date:23:38, 4 November 2010
Author:mah
Status:ok
Tags:
Comment:
Remove bogus check for !isGood() status.
Modified paths:
  • /trunk/extensions/RSS/RSSHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RSS/RSSHooks.php
@@ -38,7 +38,7 @@
3939 if ( !$status->isGood() )
4040 return wfMsg( 'rss-error', htmlspecialchars( $input), $status->getWikiText() );
4141
42 - if ( !$status->isGood() || !is_object( $rss->rss ) || !is_array( $rss->rss->items ) )
 42+ if ( !is_object( $rss->rss ) || !is_array( $rss->rss->items ) )
4343 return wfMsg( 'rss-empty', htmlspecialchars( $input ) );
4444
4545 return $rss->renderFeed( $parser, $frame );

Status & tagging log