r76056 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76055‎ | r76056 | r76057 >
Date:23:23, 4 November 2010
Author:demon
Status:ok
Tags:
Comment:
Followup r76055, missed a few more
Modified paths:
  • /trunk/phase3/includes/installer/DatabaseInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/OracleInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstaller.php
@@ -486,7 +486,7 @@
487487
488488 $s .= "</ul></div>\n". // end list pane
489489 "<div class=\"config-page\">\n" .
490 - Xml::element( 'h2', array(),
 490+ Html::element( 'h2', array(),
491491 wfMsg( 'config-page-' . strtolower( $currentPageName ) ) );
492492
493493 $this->output->addHTMLNoFlush( $s );
@@ -513,7 +513,7 @@
514514 $query['lastPage'] = $currentPageName;
515515 }
516516
517 - $link = Xml::element( 'a',
 517+ $link = Html::element( 'a',
518518 array(
519519 'href' => $this->getUrl( $query )
520520 ),
@@ -529,7 +529,7 @@
530530 $s .= $link;
531531 }
532532 } else {
533 - $s .= Xml::element( 'span',
 533+ $s .= Html::element( 'span',
534534 array(
535535 'class' => 'config-page-disabled'
536536 ),
@@ -581,7 +581,7 @@
582582 $s =
583583 "<div class=\"config-info $class\">\n" .
584584 "<div class=\"config-info-left\">\n" .
585 - Xml::element( 'img',
 585+ Html::element( 'img',
586586 array(
587587 'src' => '../skins/common/images/' . $icon,
588588 'alt' => wfMsg( 'config-information' ),
Index: trunk/phase3/includes/installer/DatabaseInstaller.php
@@ -395,7 +395,7 @@
396396 */
397397 public function getWebUserBox( $noCreateMsg = false ) {
398398 $name = $this->getName();
399 - $s = Xml::openElement( 'fieldset' ) .
 399+ $s = Html::openElement( 'fieldset' ) .
400400 Html::element( 'legend', array(), wfMsg( 'config-db-web-account' ) ) .
401401 $this->getCheckBox(
402402 '_SameAccount', 'config-db-web-account-same',
Index: trunk/phase3/includes/installer/OracleInstaller.php
@@ -57,12 +57,12 @@
5858 $this->parent->setVar( 'wgDBserver', '' );
5959 return
6060 $this->getTextBox( 'wgDBserver', 'config-db-host-oracle', array(), $this->parent->getHelpBox( 'config-db-host-oracle-help' ) ) .
61 - Xml::openElement( 'fieldset' ) .
62 - Xml::element( 'legend', array(), wfMsg( 'config-db-wiki-settings' ) ) .
 61+ Html::openElement( 'fieldset' ) .
 62+ Html::element( 'legend', array(), wfMsg( 'config-db-wiki-settings' ) ) .
6363 $this->getTextBox( 'wgDBprefix', 'config-db-prefix' ) .
6464 $this->getTextBox( '_OracleDefTS', 'config-oracle-def-ts' ) .
6565 $this->getTextBox( '_OracleTempTS', 'config-oracle-temp-ts', array(), $this->parent->getHelpBox( 'config-db-oracle-help' ) ) .
66 - Xml::closeElement( 'fieldset' ) .
 66+ Html::closeElement( 'fieldset' ) .
6767 $this->getInstallUserBox().
6868 $this->getWebUserBox();
6969 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76055Replace XML->HTML methods throughout most of the installerdemon23:21, 4 November 2010

Status & tagging log