r76024 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76023‎ | r76024 | r76025 >
Date:18:46, 4 November 2010
Author:awjrichards
Status:deferred
Tags:
Comment:
Merging r76021 through r76023 from trunk, one more last minute change
Modified paths:
  • /branches/fundraising/deployment/DonationInterface (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter5.php (modified) (history)

Diff [purge]

Index: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter5.php
@@ -55,7 +55,7 @@
5656
5757 // Xml::element seems to convert html to htmlentities
5858 $form .= "<p class='creditcard-error-msg'>" . $this->form_errors['retryMsg'] . "</p>";
59 - $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'onsubmit' => 'return validate_form(this)', 'autocomplete' => 'off' ) );
 59+ $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'autocomplete' => 'off' ) );
6060
6161 $form .= $this->generateBillingContainer();
6262 return $form;
@@ -181,7 +181,7 @@
182182 // cc submit button
183183 $form = Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-form-submit' ) );
184184 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
185 - $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=0;submit_form( this )', 'type' => 'submit' ) );
 185+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=0;submit_form( this );', 'type' => 'submit' ) );
186186 $form .= Xml::closeElement( 'div' ); // close div#mw-donate-submit-button
187187 $form .= Xml::openElement( 'div', array( 'class' => 'mw-donate-submessage', 'id' => 'payflowpro_gateway-donate-submessage' ) ) .
188188 wfMsg( 'payflowpro_gateway-donate-click' );
Property changes on: branches/fundraising/deployment/DonationInterface
___________________________________________________________________
Modified: svn:mergeinfo
189189 Merged /trunk/extensions/DonationInterface:r76022-76023

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76021fixing amount problemkaldari18:32, 4 November 2010
r76023fixing error problemkaldari18:44, 4 November 2010

Status & tagging log