r75985 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75984‎ | r75985 | r75986 >
Date:03:27, 4 November 2010
Author:kaldari
Status:deferred
Tags:
Comment:
fixing paypal redirect
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter5.php
@@ -153,7 +153,7 @@
154154 // cc submit button
155155 $form = Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-form-submit' ) );
156156 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
157 - $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=\'false\';submit_form( this )', 'type' => 'submit' ) );
 157+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=0;submit_form( this )', 'type' => 'submit' ) );
158158 $form .= Xml::closeElement( 'div' ); // close div#mw-donate-submit-button
159159 $form .= Xml::openElement( 'div', array( 'class' => 'mw-donate-submessage', 'id' => 'payflowpro_gateway-donate-submessage' ) ) .
160160 wfMsg( 'payflowpro_gateway-donate-click' );
@@ -163,8 +163,8 @@
164164 // paypal submit button
165165 $form .= Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-form-submit-paypal' ) );
166166 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
167 - $form .= Html::hidden( 'PaypalRedirect', false );
168 - $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=\'true\';document.payment.submit();', 'type' => 'submit' ) );
 167+ $form .= Html::hidden( 'PaypalRedirect', 0 );
 168+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=1;document.payment.submit();', 'type' => 'submit' ) );
169169 $form .= Xml::closeElement( 'div' ); // close div#payflowpro_gateway-donate-submessage
170170 $form .= Xml::closeElement( 'div' ); // close div#payflowpro_gateway-form-submit
171171

Status & tagging log