r75929 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75928‎ | r75929 | r75930 >
Date:13:55, 3 November 2010
Author:demon
Status:ok
Tags:
Comment:
Per CR, revert r75873. Does not match docs
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -2276,18 +2276,18 @@
22772277 private function createSkinObject() {
22782278 wfProfileIn( __METHOD__ );
22792279
2280 - global $wgHiddenPrefs, $wgRequest;
 2280+ global $wgHiddenPrefs;
22812281 if( !in_array( 'skin', $wgHiddenPrefs ) ) {
 2282+ global $wgRequest;
22822283 # get the user skin
22832284 $userSkin = $this->getOption( 'skin' );
 2285+ $userSkin = $wgRequest->getVal( 'useskin', $userSkin );
22842286 } else {
22852287 # if we're not allowing users to override, then use the default
22862288 global $wgDefaultSkin;
22872289 $userSkin = $wgDefaultSkin;
22882290 }
22892291
2290 - $userSkin = $wgRequest->getVal( 'useskin', $userSkin );
2291 -
22922292 $skin = Skin::newFromKey( $userSkin );
22932293 wfProfileOut( __METHOD__ );
22942294

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75873Cleanup r49493, r72481: Adding skin to $wgHiddenPrefs disabled the useskin pa...demon20:18, 2 November 2010

Status & tagging log