r75926 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75925‎ | r75926 | r75927 >
Date:13:41, 3 November 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
doc update
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_Setup.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_SetupLight.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialAsk.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialAsk.php
@@ -552,10 +552,11 @@
553553 $url = htmlspecialchars( $skin->makeSpecialUrl( 'Ask', "showformatoptions=\" + this.value + \"" ) );
554554
555555 foreach ( $this->m_params as $param => $value ) {
556 - if ( $param !== 'format' ) $url .= '&params[' . Xml::escapeJsString( $param ) . ']=' . Xml::escapeJsString( $value );
 556+ if ( $param !== 'format' ) {
 557+ $url .= '&params[' . Xml::escapeJsString( $param ) . ']=' . Xml::escapeJsString( $value );
 558+ }
557559 }
558560
559 - // FIXME: $url == XSS
560561 $result .= "<br /><br />\n<p>" . wfMsg( 'smw_ask_format_as' ) . ' <input type="hidden" name="eq" value="yes"/>' . "\n" .
561562 '<select id="formatSelector" name="p[format]" onChange="JavaScript:xmlhttpPost(\'' . $url . '\')">' . "\n" .
562563 ' <option value="broadtable"' . ( $this->m_params['format'] == 'broadtable' ? ' selected' : '' ) . '>' .
Index: trunk/extensions/SemanticMediaWiki/includes/SMW_SetupLight.php
@@ -14,7 +14,7 @@
1515 * @ingroup SMW
1616 */
1717
18 -define( 'SMW_VERSION', '1.5.3-light rc3' );
 18+define( 'SMW_VERSION', '1.5.3-light rc4' );
1919
2020 require_once( 'SMW_GlobalFunctions.php' );
2121
Index: trunk/extensions/SemanticMediaWiki/includes/SMW_Setup.php
@@ -8,7 +8,7 @@
99 */
1010
1111 // The SMW version number.
12 -define( 'SMW_VERSION', '1.5.3 rc3' );
 12+define( 'SMW_VERSION', '1.5.3 rc4' );
1313
1414 // A flag used to indicate SMW defines a semantic extension type for extension crdits.
1515 define( 'SEMANTIC_EXTENSION_TYPE', true );

Status & tagging log