r75869 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75868‎ | r75869 | r75870 >
Date:19:30, 2 November 2010
Author:raymond
Status:ok
Tags:
Comment:
3rd round of i18n tweaks and follow-up r75865: Use commaList()
Modified paths:
  • /trunk/extensions/WikiSync/WikiSync.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiSync/WikiSync.php
@@ -142,7 +142,7 @@
143143 }
144144
145145 static function checkUserMembership( $groups ) {
146 - global $wgUser;
 146+ global $wgUser, $wgLang;
147147 $ug = $wgUser->getEffectiveGroups();
148148 if ( !$wgUser->isAnon() && !in_array( 'user', $ug ) ) {
149149 $ug[] = 'user';
@@ -150,7 +150,7 @@
151151 if ( array_intersect( $groups, $ug ) ) {
152152 return true;
153153 }
154 - return wfMsg( 'wikisync_api_result_noaccess', implode( $groups, ',' ) );
 154+ return wfMsg( 'wikisync_api_result_noaccess', $wgLang->commaList( $groups ) );
155155 }
156156
157157 /*

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75865v 0.2.1. Separate settings for user groups allowed to perform wiki synchroniz...questpc18:57, 2 November 2010

Status & tagging log