r75842 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75841‎ | r75842 | r75843 >
Date:23:09, 1 November 2010
Author:mah
Status:ok
Tags:
Comment:
Add missing note about security re r75841
Modified paths:
  • /trunk/extensions/RSS/RSSData.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RSS/RSSData.php
@@ -16,6 +16,12 @@
1717 foreach ( $item->childNodes as $n ) {
1818 $name = $this->rssTokenToName( $n->nodeName );
1919 if ( $name != null ) {
 20+ /* Because for DOMElements the nodeValue is just
 21+ * the text of the containing element, without any
 22+ * tags, it makes this a safe, if unattractive,
 23+ * value to use. If you want to allow people to
 24+ * mark up their RSS, some more precautions are
 25+ * needed. */
2026 $bit[$name] = $n->nodeValue;
2127 }
2228 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75841* Add note about security measures we're taking....mah23:08, 1 November 2010

Status & tagging log