r75778 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75777‎ | r75778 | r75779 >
Date:02:54, 1 November 2010
Author:nad
Status:deferred
Tags:
Comment:
no need to hardwire $wgEmailPageCss into list
Modified paths:
  • /trunk/extensions/EmailPage/EmailPage.php (modified) (history)
  • /trunk/extensions/EmailPage/EmailPage_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/EmailPage/EmailPage_body.php
@@ -133,7 +133,6 @@
134134 }
135135 $db->freeResult( $res );
136136 if( $options ) {
137 - if( $wgEmailPageCss ) $options = "<option value=''>$wgEmailPageCss</option>$options";
138137 $wgOut->addHTML( "<tr id=\"ea-css\"><th align=\"right\">" . wfMsg( 'ea-style' ) . ":</th><td>" );
139138 $wgOut->addHTML( "<select name=\"ea-css\"><option />$options</select>" );
140139 $wgOut->addHTML( " <small><i>(" . wfMsg( 'ea-selectcss' ) . ")</i></small></td></tr>" );
Index: trunk/extensions/EmailPage/EmailPage.php
@@ -13,7 +13,7 @@
1414 */
1515 if( !defined( 'MEDIAWIKI' ) ) die( "Not an entry point." );
1616
17 -define( 'EMAILPAGE_VERSION', "2.1.1, 2010-11-01" );
 17+define( 'EMAILPAGE_VERSION', "2.1.2, 2010-11-01" );
1818
1919 $wgEmailPageGroup = "sysop"; # Users must belong to this group to send emails (empty string means anyone can send)
2020 $wgEmailPageCss = false; # A minimal CSS page to embed in the email (eg. monobook/main.css without portlets, actions etc)

Status & tagging log