r75768 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75767‎ | r75768 | r75769 >
Date:00:10, 1 November 2010
Author:reedy
Status:ok
Tags:
Comment:
Fix minor semi colon fail from r75767
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)
  • /trunk/phase3/includes/filerepo/File.php (modified) (history)
  • /trunk/phase3/includes/normal/UtfNormal.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/File.php
@@ -906,7 +906,7 @@
907907 $retVal = array();
908908 if ( $db->numRows( $res ) ) {
909909 foreach ( $res as $row ) {
910 - $titleObj = Title::newFromRow( $row )
 910+ $titleObj = Title::newFromRow( $row );
911911 if ( $titleObj ) {
912912 $linkCache->addGoodLinkObj( $row->page_id, $titleObj, $row->page_len, $row->page_is_redirect, $row->page_latest );
913913 $retVal[] = $titleObj;
Index: trunk/phase3/includes/normal/UtfNormal.php
@@ -308,7 +308,7 @@
309309 $len = $chunk + 1; # Counting down is faster. I'm *so* sorry.
310310
311311 for( $i = -1; --$len; ) {
312 - $remaining = $tailBytes[$c = $str{++$i}]
 312+ $remaining = $tailBytes[$c = $str{++$i}];
313313 if( $remaining ) {
314314 # UTF-8 head byte!
315315 $sequence = $head = $c;
Index: trunk/phase3/includes/Title.php
@@ -2794,7 +2794,7 @@
27952795 $retVal = array();
27962796 if ( $db->numRows( $res ) ) {
27972797 foreach ( $res as $row ) {
2798 - $titleObj = Title::makeTitle( $row->page_namespace, $row->page_title )
 2798+ $titleObj = Title::makeTitle( $row->page_namespace, $row->page_title );
27992799 if ( $titleObj ) {
28002800 $linkCache->addGoodLinkObj( $row->page_id, $titleObj, $row->page_len, $row->page_is_redirect, $row->page_latest );
28012801 $retVal[] = $titleObj;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75767bug 25517 Assignment in conditions should be avoided/ http://www.mediawiki.or...reedy00:07, 1 November 2010

Status & tagging log