r75754 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75753‎ | r75754 | r75755 >
Date:22:28, 31 October 2010
Author:nad
Status:deferred
Tags:
Comment:
add 'ALL USERS' ti i18n and use consistent quote type
Modified paths:
  • /trunk/extensions/EmailPage/EmailPage.i18n.php (modified) (history)
  • /trunk/extensions/EmailPage/EmailPage.php (modified) (history)
  • /trunk/extensions/EmailPage/EmailPage_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/EmailPage/EmailPage_body.php
@@ -69,7 +69,7 @@
7070 }
7171 if( $wgEmailPageAllowAllUsers ) {
7272 $selected = 'user' == $this->group ? ' selected' : '';
73 - $groups .= "<option$selected value='user'>ALL USERS</option>";
 73+ $groups .= "<option$selected value=\"user\">" . wfMsg( 'ea-allusers' ) . "</option>";
7474 }
7575 $wgOut->addHTML( "<tr><td>" . wfMsg( 'ea-fromgroup' ) . "</td><td><select name=\"ea-group\">$groups</select></td></tr>\n" );
7676 $wgOut->addHTML( "</table>" );
Index: trunk/extensions/EmailPage/EmailPage.i18n.php
@@ -12,26 +12,27 @@
1313 * @author Nad
1414 */
1515 $messages['en'] = array(
16 - 'emailpage' => 'E-mail page',
17 - 'ea-desc' => 'Send rendered HTML page to an e-mail address or list of addresses using [http://phpmailer.sourceforge.net phpmailer]',
 16+ 'emailpage' => "E-mail page",
 17+ 'ea-desc' => "Send rendered HTML page to an e-mail address or list of addresses using [http://phpmailer.sourceforge.net phpmailer]",
1818 'ea-heading' => "=== E-mailing the page [[$1]] ===",
19 - 'ea-fromgroup' => 'From group:',
20 - 'ea-pagesend' => 'Page "$1" sent from $2',
 19+ 'ea-fromgroup' => "From group:",
 20+ 'ea-pagesend' => "Page \"$1\" sent from $2",
2121 'ea-nopage' => "Please specify a page to send, for example \"[[Special:EmailPage/{{MediaWiki:Mainpage-url}}]]\".",
2222 'ea-norecipients' => "No valid e-mail addresses found!",
2323 'ea-listrecipients' => "=== {{PLURAL:$1|Recipient|$1 recipients}} ===",
2424 'ea-error' => "'''Error sending [[$1]]:''' ''$2''",
25 - 'ea-denied' => 'Permission denied',
 25+ 'ea-denied' => "Permission denied",
2626 'ea-sent' => "Page [[$1]] sent successfully to '''$2''' {{PLURAL:$2|recipient|recipients}} by [[User:$3|$3]].",
27 - 'ea-selectrecipients' => 'Select recipients',
28 - 'ea-compose' => 'Compose content',
 27+ 'ea-selectrecipients' => "Select recipients",
 28+ 'ea-compose' => "Compose content",
2929 'ea-selectlist' => "Email addresses can be separated with one or more semicolon, comma, asterisk or newline characters",
30 - 'ea-show' => 'Show recipients',
31 - 'ea-send' => 'Send!',
32 - 'ea-subject' => 'Enter a subject line for the e-mail',
33 - 'ea-header' => 'Prepend content with optional message (wikitext)',
34 - 'ea-selectcss' => 'Select a CSS stylesheet',
35 - 'ea-selectrecord' => 'Select a record type'
 30+ 'ea-show' => "Show recipients",
 31+ 'ea-send' => "Send!",
 32+ 'ea-subject' => "Enter a subject line for the e-mail",
 33+ 'ea-header' => "Prepend content with optional message (wikitext)",
 34+ 'ea-selectcss' => "Select a CSS stylesheet",
 35+ 'ea-selectrecord' => "Select a record type",
 36+ 'ea-allusers' => "ALL USERS"
3637 );
3738
3839 /** Message documentation (Message documentation)
Index: trunk/extensions/EmailPage/EmailPage.php
@@ -13,7 +13,7 @@
1414 */
1515 if( !defined( 'MEDIAWIKI' ) ) die( "Not an entry point." );
1616
17 -define( 'EMAILPAGE_VERSION', "2.0.0, 2010-11-01" );
 17+define( 'EMAILPAGE_VERSION', "2.0.1, 2010-11-01" );
1818
1919 $wgEmailPageGroup = "sysop"; # Users must belong to this group to send emails (empty string means anyone can send)
2020 $wgEmailPageCss = "EmailPage.css"; # A minimal CSS page to embed in the email (eg. monobook/main.css without portlets, actions etc)

Status & tagging log