r75750 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75749‎ | r75750 | r75751 >
Date:22:10, 31 October 2010
Author:hartman
Status:ok
Tags:
Comment:
Use isset to protect against Undefined index PHP notice.
Modified paths:
  • /trunk/phase3/includes/api/ApiUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiUpload.php
@@ -112,7 +112,7 @@
113113 $this->requireOnlyOneParameter( $this->mParams,
114114 'sessionkey', 'file', 'url', 'statuskey' );
115115
116 - if ( $this->mParams['statuskey'] ) {
 116+ if ( isset( $this->mParams['statuskey'] ) ) {
117117 // Status request for an async upload
118118 $sessionData = UploadFromUrlJob::getSessionData( $this->mParams['statuskey'] );
119119 if ( !isset( $sessionData['result'] ) ) {

Status & tagging log