r75679 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75678‎ | r75679 | r75680 >
Date:21:38, 29 October 2010
Author:reedy
Status:deferred
Tags:
Comment:
Case statement was falling through and assigning to the same, remove that case and have explicit fall through
Modified paths:
  • /trunk/extensions/DynamicPageList/DPLLogger.php (modified) (history)
  • /trunk/extensions/DynamicPageList/DPLMain.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DynamicPageList/DPLLogger.php
@@ -75,7 +75,6 @@
7676 $msgid = DPL_i18n::FATAL_WRONGLINKSTO;
7777 break;
7878 case 'titlemaxlength':
79 - $msgid = DPL_i18n::WARN_WRONGPARAM_INT;
8079 case 'includemaxlength':
8180 $msgid = DPL_i18n::WARN_WRONGPARAM_INT;
8281 break;
Index: trunk/extensions/DynamicPageList/DPLMain.php
@@ -47,7 +47,6 @@
4848 // Local parser created. See http://www.mediawiki.org/wiki/Extensions_FAQ#How_do_I_render_wikitext_in_my_extension.3F
4949 $localParser = new Parser();
5050 $pOptions = $parser->mOptions;
51 - $pTitle = $parser->mTitle;
5251
5352 // check if DPL shall only be executed from protected pages
5453 if ( array_key_exists( 'RunFromProtectedPagesOnly', ExtDynamicPageList::$options ) &&
@@ -3379,7 +3378,7 @@
33803379 $aTableRow = array();
33813380 $groupNr = - 1;
33823381 $t = - 1;
3383 - foreach ( $aSecLabels as $colgroup => $label ) {
 3382+ foreach ( $aSecLabels as $label ) {
33843383 $t++;
33853384 $groupNr++;
33863385 $cols = split( '}:', $label );

Status & tagging log