r75602 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75601‎ | r75602 | r75603 >
Date:00:04, 28 October 2010
Author:reedy
Status:ok
Tags:
Comment:
Function return type hints

Explicit class variable definition
Modified paths:
  • /trunk/phase3/includes/api/ApiRollback.php (modified) (history)
  • /trunk/phase3/includes/api/ApiUserrights.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialBlockip.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiRollback.php
@@ -154,6 +154,9 @@
155155 return $this->mUser;
156156 }
157157
 158+ /**
 159+ * @return Title
 160+ */
158161 private function getTitle() {
159162 if ( $this->mTitleObj !== null ) {
160163 return $this->mTitleObj;
Index: trunk/phase3/includes/api/ApiUserrights.php
@@ -58,6 +58,9 @@
5959 $this->getResult()->addValue( null, $this->getModuleName(), $r );
6060 }
6161
 62+ /**
 63+ * @return User
 64+ */
6265 private function getUser() {
6366 if ( $this->mUser !== null ) {
6467 return $this->mUser;
Index: trunk/phase3/includes/specials/SpecialBlockip.php
@@ -28,7 +28,8 @@
2929 * @ingroup SpecialPage
3030 */
3131 class IPBlockForm extends SpecialPage {
32 - var $BlockAddress, $BlockExpiry, $BlockReason;
 32+ var $BlockAddress, $BlockExpiry, $BlockReason, $BlockReasonList, $BlockOther, $BlockAnonOnly, $BlockCreateAccount,
 33+ $BlockEnableAutoblock, $BlockEmail, $BlockHideName, $BlockAllowUsertalk, $BlockReblock;
3334 // The maximum number of edits a user can have and still be hidden
3435 const HIDEUSER_CONTRIBLIMIT = 1000;
3536

Status & tagging log