r75594 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r75593‎ | r75594 | r75595 >
Date:23:20, 27 October 2010
Author:hartman
Status:deferred
Tags:
Comment:
Fix some undefined properties.
Modified paths:
  • /branches/MwEmbedStandAlone/mwEmbedFrame.php (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/mwEmbedFrame.php
——@@ -32,6 +32,7 @@
3333 'skin'
3434 );
3535 var $playerIframeId = 'iframeVid';
 36+ var $debug = false;
3637
3738 // When used in direct source mode the source asset.
3839 // NOTE: can be an array of sources in cases of "many" sources set
——@@ -96,7 +97,7 @@
9798 // Setup the embed string based on attribute set:
9899 $embedResourceList = 'window.jQuery,mwEmbed,mw.style.mwCommon,$j.fn.menu,mw.style.jquerymenu,mw.EmbedPlayer,mw.EmbedPlayerNative,mw.EmbedPlayerJava,mw.PlayerControlBuilder,$j.fn.hoverIntent,mw.style.EmbedPlayer,$j.cookie,$j.ui,mw.style.ui_redmond,$j.widget,$j.ui.mouse,mw.PlayerSkinKskin,mw.style.PlayerSkinKskin,mw.TimedText,mw.style.TimedText,$j.ui.slider';
99100
100 - if( $this->kentryid ){
 101+ if( isset( $this->kentryid ) ){
101102 $embedResourceList.= ',' . implode(',', array(
102103 'KalturaClientBase',
103104 'KalturaClient',

Status & tagging log