r75556 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75555‎ | r75556 | r75557 >
Date:15:51, 27 October 2010
Author:platonides
Status:ok
Tags:
Comment:
r74753, r74755, r75254 added new settings, but didn't update SeleniumConfigurationTest.php breaking the tests
Modified paths:
  • /trunk/phase3/maintenance/tests/phpunit/includes/SeleniumConfigurationTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/includes/SeleniumConfigurationTest.php
@@ -23,6 +23,10 @@
2424 username = "xxxxxxx"
2525 userPassword = ""
2626 testBrowser = "chrome"
 27+startserver =
 28+stopserver =
 29+jUnitLogFile =
 30+runAgainstGrid = false
2731
2832 [SeleniumTests]
2933 testSuite[SimpleSeleniumTestSuite] = "maintenance/tests/selenium/SimpleSeleniumTestSuite.php"
@@ -44,7 +48,12 @@
4549 'wikiUrl' => 'http://localhost/deployment',
4650 'username' => 'xxxxxxx',
4751 'userPassword' => '',
48 - 'testBrowser' => 'chrome'
 52+ 'testBrowser' => 'chrome',
 53+ 'startserver' => null,
 54+ 'stopserver' => null,
 55+ 'seleniumserverexecpath' => null,
 56+ 'jUnitLogFile' => null,
 57+ 'runAgainstGrid' => null
4958 );
5059 /*
5160 * Array of expected testSuites from $testConfig0
@@ -77,7 +86,12 @@
7887 'wikiUrl' => null,
7988 'username' => null,
8089 'userPassword' => null,
81 - 'testBrowser' => 'firefox'
 90+ 'testBrowser' => 'firefox',
 91+ 'startserver' => null,
 92+ 'stopserver' => null,
 93+ 'seleniumserverexecpath' => null,
 94+ 'jUnitLogFile' => null,
 95+ 'runAgainstGrid' => null
8296 );
8397 /*
8498 * Expected test suites from $testConfig1

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74753* start / stop selenium server on Linux...mglaser00:06, 14 October 2010
r74755added support for junit log file output, which is neede by phpUnderControlmglaser00:42, 14 October 2010
r75254added settings to run tests against a selenium gridmglaser15:52, 23 October 2010

Status & tagging log