r75484 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75483‎ | r75484 | r75485 >
Date:22:51, 26 October 2010
Author:reedy
Status:ok
Tags:
Comment:
Explicit class variables, fix call to obsolete method
Modified paths:
  • /trunk/extensions/CodeReview/api/ApiCodeComments.php (modified) (history)
  • /trunk/extensions/CodeReview/api/ApiCodeRevisions.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/api/ApiCodeComments.php
@@ -24,6 +24,8 @@
2525 */
2626
2727 class ApiCodeComments extends ApiQueryBase {
 28+ private $props;
 29+
2830 public function __construct( $query, $moduleName ) {
2931 parent::__construct( $query, $moduleName, 'cc' );
3032 }
Index: trunk/extensions/CodeReview/api/ApiCodeRevisions.php
@@ -25,6 +25,8 @@
2626 */
2727
2828 class ApiCodeRevisions extends ApiQueryBase {
 29+ private $props;
 30+
2931 public function __construct( $query, $moduleName ) {
3032 parent::__construct( $query, $moduleName, 'cr' );
3133 }
Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -133,7 +133,7 @@
134134 Xml::buildForm( $changeFields, 'codereview-batch-submit' ) );
135135
136136 $changeInterface .= $pager->getHiddenFields();
137 - $changeInterface .= Xml::hidden( 'wpBatchChangeEditToken', $wgUser->editToken() );
 137+ $changeInterface .= Html::hidden( 'wpBatchChangeEditToken', $wgUser->editToken() );
138138
139139 return $changeInterface;
140140 }

Status & tagging log