r75422 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75421‎ | r75422 | r75423 >
Date:14:08, 26 October 2010
Author:platonides
Status:ok
Tags:
Comment:
Keep it in Title.php Having it on Defines would allow to use it wrong.
Follow up r75379 (r74035, r74034)
Modified paths:
  • /trunk/phase3/includes/Defines.php (modified) (history)
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Defines.php
@@ -238,12 +238,6 @@
239239 */
240240 define( 'RLH_FOR_UPDATE', 1 );
241241
242 -/**
243 - * @deprecated This used to be a define in Title.php, but was moved to
244 - * Title::GAID_FOR_UPDATE in 1.17. This will probably be removed in 1.18
245 - */
246 -define( 'GAID_FOR_UPDATE', 1 );
247 -
248242 /**@{
249243 * Autopromote conditions (must be here and not in Autopromote.php, so that
250244 * they're loaded for DefaultSettings.php before AutoLoader.php)
Index: trunk/phase3/includes/Title.php
@@ -14,6 +14,12 @@
1515 }
1616
1717 /**
 18+ * @deprecated This used to be a define, but was moved to
 19+ * Title::GAID_FOR_UPDATE in 1.17. This will probably be removed in 1.18
 20+ */
 21+define( 'GAID_FOR_UPDATE', Title::GAID_FOR_UPDATE );
 22+
 23+/**
1824 * Represents a title within MediaWiki.
1925 * Optionally may contain an interwiki designation or namespace.
2026 * @note This class can fetch various kinds of data from the database;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74034Refactor GAID_FOR_UPDATE into Title::GAID_FOR_UPDATE. Yay less file-scope cod...demon19:13, 30 September 2010
r74035Follow up r74034: Refactor GAID_FOR_UPDATE into Title::GAID_FOR_UPDATE. Yay l...demon19:14, 30 September 2010
r75379Followup r74035, add GAID_FOR_UPDATE to the defines for back-compatdemon20:25, 25 October 2010

Status & tagging log