r75409 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75408‎ | r75409 | r75410 >
Date:03:20, 26 October 2010
Author:kaldari
Status:ok
Tags:
Comment:
follow up to r75222, using encodeURIComponent() and adding missing ampersand
Modified paths:
  • /trunk/extensions/CentralNotice/SpecialBannerController.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/SpecialBannerController.php
@@ -69,7 +69,7 @@
7070 var geoLocation = Geo.country; // pull the geo info
7171 }
7272 var bannerListQuery = $.param( { 'language': wgContentLanguage, 'project': wgNoticeProject, 'country': geoLocation } );
73 - var bannerListURL = wgScript + '?title=' + wgFormattedNamespaces[-1] + ':BannerListLoader&cache=/cn.js' + bannerListQuery;
 73+ var bannerListURL = wgScript + '?title=' + encodeURIComponent(wgFormattedNamespaces[-1]) + ':BannerListLoader&cache=/cn.js&' + bannerListQuery;
7474 var request = $.ajax( {
7575 url: bannerListURL,
7676 dataType: 'json',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75222fix for Bug 25564 (won't fix stats for meta), to test on Mondaykaldari23:51, 22 October 2010

Status & tagging log