r75374 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75373‎ | r75374 | r75375 >
Date:19:34, 25 October 2010
Author:kaldari
Status:ok
Tags:
Comment:
more concise
Modified paths:
  • /trunk/extensions/CentralNotice/SpecialBannerController.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/SpecialBannerController.php
@@ -63,14 +63,13 @@
6464 $( '#siteNotice' ).prepend( '<div id="centralNotice" class="' + ( wgNoticeToggleState ? 'expanded' : 'collapsed' ) + '">'+bannerScript+'</div>' );
6565 },
6666 'loadBannerList': function( geoOverride ) {
67 - var bannerListURL;
6867 if ( geoOverride ) {
6968 var geoLocation = geoOverride; // override the geo info
7069 } else {
7170 var geoLocation = Geo.country; // pull the geo info
7271 }
7372 var bannerListQuery = $.param( { 'title': wgFormattedNamespaces[-1] + ':BannerListLoader', 'language': wgContentLanguage, 'project': wgNoticeProject, 'country': geoLocation, 'cache': 'cn.js' } );
74 - bannerListURL = wgScript + '?' + bannerListQuery;
 73+ var bannerListURL = wgScript + '?' + bannerListQuery;
7574 var request = $.ajax( {
7675 url: bannerListURL,
7776 dataType: 'json',

Follow-up revisions

RevisionCommit summaryAuthorDate
r75380Syncing to head of trunk at r75374tomasz21:18, 25 October 2010
r75845Adding in r75374tomasz23:46, 1 November 2010

Status & tagging log