r75354 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75353‎ | r75354 | r75355 >
Date:14:41, 25 October 2010
Author:demon
Status:ok
Tags:
Comment:
Revert mainpage part of r75347. Should go in its own method, with messages, proper error handling, and should fix bug 22308 (trivial)
Modified paths:
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/Installer.php
@@ -357,22 +357,6 @@
358358 if( $status->isOK() ) {
359359 LBFactory::enableBackend();
360360 }
361 -
362 -
363 - $titleobj = Title::newFromText( wfMsgNoDB( "mainpage" ) );
364 - $article = new Article( $titleobj );
365 - $newid = $article->insertOn( $installer->db );
366 - $revision = new Revision( array(
367 - 'page' => $newid,
368 - 'text' => wfMsg( 'mainpagetext' ) . "\n\n" . wfMsgNoTrans( 'mainpagedocfooter' ),
369 - 'comment' => '',
370 - 'user' => 0,
371 - 'user_text' => 'MediaWiki default',
372 - ) );
373 - $revid = $revision->insertOn( $installer->db );
374 - $article->updateRevisionOn( $installer->db, $revision );
375 -
376 - return $status;
377361 }
378362
379363 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r75366* DatabaseOracle - throw connection exception instead of debug+false...freakolowsky16:49, 25 October 2010
r75654(bug 22308) Search should find text in default main page immediately after se...demon17:26, 29 October 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75347* Installer for Oracle fixes...freakolowsky11:07, 25 October 2010

Status & tagging log