r75342 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75341‎ | r75342 | r75343 >
Date:21:02, 24 October 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Comment out unused if (code inside it is commented out
Modified paths:
  • /trunk/phase3/includes/db/DatabaseMysql.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseMysql.php
@@ -76,10 +76,10 @@
7777 # Create a new connection...
7878 $this->mConn = mysql_connect( $realServer, $user, $password, true );
7979 }
80 - if ($this->mConn === false) {
 80+ #if ( $this->mConn === false ) {
8181 #$iplus = $i + 1;
8282 #wfLogDBError("Connect loop error $iplus of $max ($server): " . mysql_errno() . " - " . mysql_error()."\n");
83 - }
 83+ #}
8484 }
8585 $phpError = $this->restoreErrorHandler();
8686 # Always log connection errors

Comments

#Comment by Hashar (talk | contribs)   21:32, 25 October 2010

I am almost sure this is a live hack. We can probably make it a setting.

#Comment by 😂 (talk | contribs)   21:34, 25 October 2010

Whee more single-purpose globals.

Status & tagging log